Add GitHub Actions release workflow and fix Windows build#1497
Closed
WatchKitty wants to merge 1 commit into
Closed
Add GitHub Actions release workflow and fix Windows build#1497WatchKitty wants to merge 1 commit into
WatchKitty wants to merge 1 commit into
Conversation
WatchKitty
force-pushed
the
codex/add-release-workflow
branch
from
804f7e1 to
af566c5
Compare
WatchKitty
force-pushed
the
codex/add-release-workflow
branch
from
af566c5 to
c3e0e9a
Compare
WatchKitty
changed the title
Owner
|
The workflow was deliberately removed since it's way too chaos |
Owner
|
Also, due to the term "CI", each push into a PR will get built and due to how people generally want to chase "new", malicious commits can use this as an attack surface, so it's better left off. |
Author
|
Thanks, that makes sense. I didn’t realize the release workflow had been intentionally removed before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a GitHub Actions release workflow that can build the Windows NSIS installer on GitHub-hosted Windows runners.
The workflow supports:
v*that build and publish a GitHub Release assetworkflow_dispatchreleases with configurable tag, draft, prerelease, and publish toggles--clobberThis also fixes a current Windows build blocker in the AMF H.264 options:
config_thas noprofilefield, so the AMF encoder now sets the existing fallback value (high) directly.Why
The repository already documents remote builds, and the recent GHSA-ph75-mgxh-mv57 / CVE-2026-32253 backport would be easier for regular users to consume if maintainers can produce a cloud-built installer and release asset directly from GitHub.
Validation
.github/workflows/release.ymlwithyaml@2.actionlintagainst the workflow.npmin the MSYS2 shell, then the second run exposed the existingconfig_t::profileWindows build error. Both have been addressed in this branch.